Thomas Watson

Results 112 comments of Thomas Watson

I somehow can't get the normal test suite to run in `master`. Is it because I have cloned this repo into a folder whos path already contain a `node_modules` folder?...

Installed in `/tmp` and it worked. So I guess it's related to the `node_modules` folder in the path

As far as I can see, no where in the current tests do you validate that `require.sync` returns the same result as `require.resolve`. Is this on purpose?

All Opbeat need to know is the name of the route (with name I mean `/user/:id` as opposed to `/user/42`). So if you expose the route name in some easy...

I've been looking over merry, server-router and wayfarer now and can't seem to find a place where this string is accessible. If it ins't, would you consider exposing it in...

Yeah, the route name. If that could be exposed we'd have full support 😄 Here's an explanation: https://opbeat.com/docs/articles/get-started-with-a-custom-nodejs-stack/#route-naming

I guess the [`Trie.prototype.match`](https://github.com/yoshuawuyts/wayfarer/blob/904a075bd147cb66865d56d02fc60af1bb029487/trie.js#L51-L80) function needed to be modified. But I only spend a few minutes looking over it, so I'm not sure if there's a better spot

@david-luna yes, please if you don't mind to open a PR against `original-url`, then I'll take a look ❤️

For later reference: Greenkeeper have made a PR to upgrade to v10.3.2 at #107

The work to fix this have now been moved to https://github.com/nodejs/node/pull/12861