async-listener icon indicating copy to clipboard operation
async-listener copied to clipboard

net.connect issue with Node.js 7.10.0

Open watson opened this issue 7 years ago • 1 comments

A commit recently landed in Node core that was released as v7.10.0 two days ago.

It breaks async-listener because net.connect no longer calls Socket.prototype.connect. Furthermore, it's not possible to simply monkey-patch net.connect because it's being called internally in node by simply referencing the connect function and not the exports.connect function.

I'm working on fixing this together with @cjihrig and @jasnell. See https://github.com/nodejs/node/pull/12852 for details.

It will most likely be released as v7.10.1.

watson avatar May 05 '17 09:05 watson

The work to fix this have now been moved to https://github.com/nodejs/node/pull/12861

watson avatar May 08 '17 20:05 watson