Suprit S Jahagirdar
Suprit S Jahagirdar
Thanks for replying, @perazz ! When I started working on this, I thought of ways to integrate the two but couldn't really find any such way... As these are more...
Thank you very much for the refactor @perazz I have added the test incorporating the procedure, do let me know what you think about it.
Thank you for your reviews everyone. It seems these procedures are not documented at all. So there is nothing to change really. But maybe I should add them now? since...
I don't mind at all @jalvesz, thank you very much for the refactor. `ascii` module was missing docs of the constants and some procedures (that are now elemental) it provides,...
Yes @jalvesz I have added all the missing specs of the module.
@perazz @jalvesz I think there are pros and cons to both the approaches, The `elemental` checking one proposed by @jalvesz does what it's for but I don't think we should...
Ping @perazz
Thank you very much @jalvesz for your detailed remarks, they are quite helpful. I have refactored the algorithm to only accept `p`, as `n` can very well be calculated from...
Thank you @jalvesz, I have implemented them accordingly and added some better examples although I am not sure of how I may test the correctness of multiplication with large matrices...
I have replaced all the `matmul`'s by calls to `gemm`... The code has become a bit complicated and verbose... If I have missed anything or there was a shorter way...