Muhammad Waqar
Muhammad Waqar
Like to work on #1263
@KJhellico @arkid15r I'm unable to figure out what is going bad now can you please help me with it?
> You have issue with `hoildays/countries/__init__.py` (you wrongly [reverted changes](https://github.com/waqar2403/holidays/commit/5c60b9f6f54b6f361c301771086ffc924d3d24fc) after merging from `dev`. Take the current version and add your line. I hope [this](https://github.com/vacanza/holidays/pull/2608/commits/dd6ab801e77196c73baa5069ed4b592720d36cd4) works now
@KJhellico I’ve made the changes according to your suggestion the timeanddate.com data threw me off because I wasn’t aware of its reliability, and @PPsyrius I’ve also updated the test suite...
@KJhellico I've updated my branch but still it is getting merge conflict error can you please help me with it?
> Quote reply @PPsyrius thanks for pointing out it's actually the 1st Monday of july and I Fixed it + your PR is merged to my main branch
> Revert New Year's Day changes. @KJhellico [2023](https://web.archive.org/web/20240225145904/https://www.bosvg.com/wp-content/uploads/2023/03/BOSVG-CALENDAR-TENT_F_REPRINT_TENT-EXCLUDED-FINAL.pdf)
> Hopefully the last changes before this PR is merged in 👍 (please run `make snapshot` after this as well to update the snapshots) 🤞
@arkid15r Hi I'm working on this issue and it's my first time working on holidays. for now - Went through the Contributing guide - Forking and Local setup - Checking...
@arkid15r I just went through the eligibility criteria can I work on two PRs in parallel one for sponsorship and another to fulfill the eligibility criteria?