Weijun Wang

Results 75 comments of Weijun Wang

The code at https://github.com/openjdk/jdk/blob/ddf04617887dc389cd7667e820da7ac91eea9e8c/src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java#L449 is old. It does not cover the public key case. Reproducer: ``` var pass = "changeit".toCharArray(); var kp = KeyPairGenerator.getInstance("X25519").generateKeyPair(); var sk2 = PEMDecoder.of().decode(PEMEncoder.of().encodeToString(kp), PrivateKey.class); //...

Please implement the key checks at the beginnings of sections 7.2 and 7.3 of FIPS 203 in `implCheckPublicKey` and `implCheckPrivateKey` so it can detected earlier in `newEcapsulator` and `newDecapsulator`. The...

Have you timed the differences? I remember we've deliberately used small key sizes for RSA and DSA in some tests because large sizes could be very slow.