jdk 8342181: Update tests to use stronger Key and Salt size

Several tests currently use weak key and salt sizes. Since the purpose of these tests is not to evaluate weak keys, they can be updated to use stronger keys length (2048-bits) and stronger Salt (16 bytes). This PR does not intend to update the tests to use stronger algorithms.

There is no significant increase in tests run time, those still complete consistently fast (few seconds).

Progress

[ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
[x] Change must not contain extraneous whitespace
[x] Commit message must refer to an issue

Issue

JDK-8342181: Update tests to use stronger Key and Salt size (Sub-task - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21537/head:pull/21537
$ git checkout pull/21537

Update a local copy of the PR:
$ git checkout pull/21537
$ git pull https://git.openjdk.org/jdk.git pull/21537/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21537

View PR using the GUI difftool:
$ git pr show -t 21537

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21537.diff

Webrev

Link to Webrev Comment

Oct 16 '24 12:10 fguallini

:wave: Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Oct 16 '24 12:10 bridgekeeper[bot]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342181: Update tests to use stronger Key and Salt size

Reviewed-by: rhalade, ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

cc2fb4d3bd52a0f0b2c92e0b5490e003f9ba55ee: 8337276: jcmd man page update for PID in output filenames
02ea4b548ea1d5e96b9e59e2aa916d7728844116: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir
7461dfe9c652542ef4e8f8fe36ac601ebd345492: 8341788: Fix ExceptionOccurred in hotspot

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade, @ascarpino) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Oct 16 '24 12:10 openjdk[bot]

@fguallini The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Oct 16 '24 12:10 openjdk[bot]

Webrevs

Oct 17 '24 11:10 mlbridge[bot]

Can key size and salt size be configurable somehow; either as system property or a constant? This will make it easier to modify in future without updating all these tests again.

Oct 17 '24 18:10 rhalade

Have you timed the differences? I remember we've deliberately used small key sizes for RSA and DSA in some tests because large sizes could be very slow.

Oct 21 '24 13:10 wangweij

@wangweij Yes, test execution time was taken into consideration. A few tests were generating keys in a loop, which significantly increased their execution time; so those tests were not included in this PR. Only tests that did not have a significant impact on execution time, only a for few seconds, were included. None of these test run for longer than 30 seconds, and the total execution time for the group has only increased by 10-30 seconds depending on the platform

Oct 21 '24 15:10 fguallini

/integrate

Oct 30 '24 21:10 fguallini

@fguallini Your change (at version 7827baa8f5d3dc9a30fbbf4efb04ba6002883933) is now ready to be sponsored by a Committer.

Oct 30 '24 21:10 openjdk[bot]

/sponsor

Oct 30 '24 22:10 rhalade

Going to push as commit f340ab2d360b5dfd375095ac053e9f4fc22a98de. Since your change was applied there have been 3 commits pushed to the master branch:

cc2fb4d3bd52a0f0b2c92e0b5490e003f9ba55ee: 8337276: jcmd man page update for PID in output filenames
02ea4b548ea1d5e96b9e59e2aa916d7728844116: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir
7461dfe9c652542ef4e8f8fe36ac601ebd345492: 8341788: Fix ExceptionOccurred in hotspot

Your commit was automatically rebased without conflicts.

Oct 30 '24 22:10 openjdk[bot]

@rhalade @fguallini Pushed as commit f340ab2d360b5dfd375095ac053e9f4fc22a98de.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Oct 30 '24 22:10 openjdk[bot]