Results 16 comments of Lin Wang
trafficstars

感觉return [err,results]的方式进行错误处理比较好啊,不然的话单纯使用try ... catch ... 语句块无法为后续代码指明之前的执行结果是否有误,需要加入额外变量去完成。

> @wanglam How can i validate this change? Can ou add testing instructions to the PR description? It makes reviewing PR's a lot easier Hi Ashwin, I think we can...

@ruanyl @SuZhou-Joe I've add permission validate for the `deleteByWorkspace` method. Could you help me to review it ? Thank you.

> @wanglam, how do i add the two users you mentioned in the testing steps? admin and another-user? Also is there a functional test for this change? If so can...

Hi @Flyingliuhub , thank you for helping me testing the PR. Could you paste your `opensearch_dashboards.yml` here? ```yml opensearch.ssl.verificationMode: none opensearch.requestHeadersWhitelist: [authorization, securitytenant] workspace.enabled: true savedObjects.permission.enabled: true ``` This is...

> > ``` > > workspace.enabled: true > > ``` > > > > > > > > > > > > > > > > > > > >...

> > It seems this error doesn't caused by current PR. I've tested in the main branch and try to create workspace with permissions property using devtools. It throw the...

将module-federation-remote中的library.type改为window 就能work了。 ```js new ModuleFederationPlugin({ name: "eppComponent", library: { type: "window", name: "eppComponent" }, filename: "mf.js", exposes: { "./tester": path.resolve(__dirname, "./tester.jsx"), }, }), ```

> @wanglam do you have a chance to verify the all different cases for import sample data. And how to work with MDS to add sample data too > >...