Victor Wang

Results 24 comments of Victor Wang

@xiaoxiang781216 @Fix-Point This looks similar to the hrtimer driver I planned to add in my PR https://github.com/apache/nuttx/pull/17065, which was intended to provide access to the hardware timer count. However, @xiaoxiang781216...

> you can't disable signals under POSIX. As much as I like this change and minimizing the footprint of NuttX, this change is against INVIOLABLES.md and it certainly can't be...

> @wangchdo > > Some SIG APIs can use empty definitions, which reduces the number of macro definitions in the code: > > Another key change is that the `usleep/sleep`...

> > you can't disable signals under POSIX. As much as I like this change and minimizing the footprint of NuttX, this change is against INVIOLABLES.md and it certainly can't...

> Thanks @wangchdo I did take a look at the changes, my questions below :-) > > > When signals are disabled, the related POSIX APIs—including sleep, usleep, kill, pkill,...

> > When signals are disabled, the related POSIX APIs—including sleep, usleep, kill, pkill, and pthread—will be disabled as well. > > It's too limit that sleep/usleep can't be called...

> > > > When signals are disabled, the related POSIX APIs—including sleep, usleep, kill, pkill, and pthread—will be disabled as well. > > > > > > > >...

> > > > When signals are disabled, the related POSIX APIs—including sleep, usleep, kill, pkill, and pthread—will be disabled as well. > > > > > > > >...

> > > > 1. Please refer to [sched/signal: Add support to disable signals #17352](https://github.com/apache/nuttx/pull/17352) as the primary commit; @wangchdo submitted this change first. > > > > 2. cc...

> > > The detailed implementation is different, both approach could benefit in the different usage. It's better to introduce the disable level concept, so both pr could be merged....