Chines Wang

Results 6 comments of Chines Wang
trafficstars

Similarly, in wake.rs, using SeqCst is unnecessary. Using Acquire/Release would be sufficient. https://github.com/crossbeam-rs/crossbeam/blob/95d0bd04624473b546826fdb97f10abe849443e4/crossbeam-channel/src/waker.rs#L200-L203 https://github.com/crossbeam-rs/crossbeam/blob/95d0bd04624473b546826fdb97f10abe849443e4/crossbeam-channel/src/waker.rs#L211-L214 https://github.com/crossbeam-rs/crossbeam/blob/95d0bd04624473b546826fdb97f10abe849443e4/crossbeam-channel/src/waker.rs#L221 https://github.com/crossbeam-rs/crossbeam/blob/95d0bd04624473b546826fdb97f10abe849443e4/crossbeam-channel/src/waker.rs#L223 https://github.com/crossbeam-rs/crossbeam/blob/95d0bd04624473b546826fdb97f10abe849443e4/crossbeam-channel/src/waker.rs#L226-L229 https://github.com/crossbeam-rs/crossbeam/blob/95d0bd04624473b546826fdb97f10abe849443e4/crossbeam-channel/src/waker.rs#L239-L242 https://github.com/crossbeam-rs/crossbeam/blob/95d0bd04624473b546826fdb97f10abe849443e4/crossbeam-channel/src/waker.rs#L250-L253 https://github.com/crossbeam-rs/crossbeam/blob/95d0bd04624473b546826fdb97f10abe849443e4/crossbeam-channel/src/waker.rs#L261-L264

> I used `SeqCst` in part because I didn't want to do the analysis necessary to demonstrate that a less restrictive ordering was correct, and also because I didn't perceive...

> > I used `SeqCst` in part because I didn't want to do the analysis necessary to demonstrate that a less restrictive ordering was correct, and also because I didn't...

> There is precedent for this in #6018, so I guess I am okay with a PR. Does the suggested ordering for the atomic operations seem reasonable? If it is,...

> Acquire/release is probably correct in most places, but I'd have to look at the specific code to know for sure. I'm slightly uncertain about the usage of the following...

https://github.com/tokio-rs/tokio/pull/6268