Ben Kelly

Results 228 comments of Ben Kelly

Also, I wonder if the Map oriented approach to associating data with entries will make it hard to have a constructor that takes dictionaries instead of full URLPatterns. Not sure...

> I've always been -1 on the map-oriented approach, myself. Really? I thought you suggested it to me before. I must have been confused. Should we use a maplike API...

Ok, I recall you were positive on passing in an array of init dictionaries to the constructor. But that doesn't seem to work with the external map approach. Does that...

To clarify, if you pass in an init dictionary and the constructor makes the URLPattern for you, then you don't have the pattern as a key in your Map.

I think this one is working as intended. Its behavior inherited from path-to-regexp. Also, its unclear to me how to implement this in the general sense. Consider that a repeated...

Interesting idea, but I must admit I don't understand what this would be used for. Can you describe the use case? Thanks.

One of the difficulties I ran into with exposing toRegExp was that the path-to-regexp algorithm does not use named regexp groups. It wants to maintain compatibility with older regexp engines...

For tooling that runs outside of the browser I was imagining folks would use the polyfill or path-to-regexp directly in some kind of build automation.

Wildcards are unnamed matching groups today. So they do indeed get an automatically assigned numeric name.

Just to clarify some terminology, URLPattern is based on URL canonicalization. So search values are encoded and unparsed. URLSearchParams parses and decodes a search string, but generally that is not...