Ben Kelly
Ben Kelly
In the time since I requested the review the spec has been written. There are also multiple implementations shipped. The permitted characters are aligned with those permitted by javascript identifiers:...
I'm going to close this for now, but please re-open if there is new feedback.
Also: > check that a radix tree implementation is possible (implement in Deno) I doubt the API shape here will really dictate whether a radix tree implementation is possible or...
> What do you think about including this intermediate format in the spec? I don't think we should put any intermediate representation in the spec as it then makes future...
Also, when this is further along it would be nice to include a "mini explainer" in the pull request description. Something like https://github.com/whatwg/dom/pull/1032. And submit to TAG review. Besides helping...
I think @domenic had previously advocated the map approach to me. If this is ergonomic enough for developers, that works for me.
@lucacasonato What is the status of this? How did your prototyping in deno go? I'm thinking of prototyping this in chromium using re2's set implementation.
I was also wondering if we should rename this to `URLPatternSet`. My impression is we don't want to support duplicate entries.
I filed an intent to prototype for chromium: https://groups.google.com/a/chromium.org/g/blink-dev/c/QrPrveVyFnA/m/PkaPKfJ4AwAJ
@domenic Do you think we should include `setlike` in the webidl here? (Again, I think we should probably make this URLPatternSet.) Edit: Note, the URLPatternSet will be ordered, but not...