Walter Simson
Walter Simson
Refactor [make_line](https://github.com/waltsims/k-wave-python/blob/9d5b4682139056fa232dafc8e2b3f891252492c0/kwave/utils/mapgen.py#L988). The function is too long and confusing and could be broken down into subfunctions and simplified.
https://stackoverflow.com/a/58930304 Allow for so specific downloads
This PR adds darwin cpu execution of k-wave simulations and depends on darwin compilation of the binaries which will be published to github shortly. closes #69
In the k-wave project, and thus also for k-wave-python, the flag alpha_mode=no_dispersion has no effect during compiled execution. We should warn the user of this behavior https://github.com/waltsims/k-wave-python/blob/8a5e46ab7ead44bf3b0e3c57f6f203f197c03815/kwave/kmedium.py#L61
**To Reproduce** Add the following lines to tests/test_checks.py ```python import logging logging.basicConfig(level=logging.DEBUG) ``` The file produces many logging errors **Expected behavior** logging should not throw errors
**Describe the bug** When running an axis-symmetric simulation with the simulation option `pml_auto=True`, the following warning is still raised: ``` WARNING:root:Highest prime factors in each dimension are [ 3 109]...
The test case here could be updated to compare against matlab output as documented [here](https://k-wave-python.readthedocs.io/en/latest/development/development_environment.html). Furthermore, the test could be updated to better imitate the ivp_axisymmetric example with k-array. This...