gchin comments

Results 9 comments of


                                            gchin

Write a test to find out what happens when data low water is bigger than actual device

@mulkieran, device mapper seems to not care about the low water mark being too large. [gchin@to-be-determined stratis-storage]$ lsblk NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT sda 8:0 0 119.2G 0...

Write a test to find out what happens when data low water is bigger than actual device

[gchin@to-be-determined devicemapper-rs]$ sudo dmsetup table thin1 0 8388608 thin-pool 8:17 8:18 2048 9999999999999999999 0

Check for correctness of feature argument number when parsing feature arguments

Rebased.

Check for correctness of feature argument number when parsing feature arguments

@mulkieran: Here is the relevant snippet of the `make test` output: ``` failures: ---- lineardev::tests::test_flakey_incorrect_feature_args_input stdout ---- thread 'lineardev::tests::test_flakey_incorrect_feature_args_input' panicked at 'index 9 out of range for slice of length...

Check for correctness of feature argument number when parsing feature arguments

Rebased

Check for correctness of feature argument number when parsing feature arguments

@mulkieran Should the fixes for the other targets be done in separate PRs or the same PR as Flakey?

Check for correctness of feature argument number when parsing feature arguments

Rebased

Check for correctness of feature argument number when parsing feature arguments

I pushed a commit containing all of the changes you explicitly requested. Regarding the test you provided: This test causes a panic at the assertion that the input results in...

Check for correctness of feature argument number when parsing feature arguments

@mulkieran. That test looks reasonable to me and it passes when run against the source code changes of my most recently pushed commit. Adding your test to the PR now.