Peter Wagenet

icon indicating an email [email protected]

icon company @soxhub icon location Orange County, CA icon location Staff Engineer at AuditBoard, @emberjs Core Team Member

Results 357 comments of Peter Wagenet

Runner Registration Being Deleted In the Middle of Running Jobs

@aiell0 are you suggesting downgrading?

v3.6.0-beta.1: redirect causes `visit` test helper to fail

Looks like the same as #17152. See https://github.com/wagenet/ember-transition-abort-test which passes on latest and beta, but fails on canary, as visible here: https://travis-ci.com/wagenet/ember-transition-abort-test. The commit that causes issues is 9b7e0f5, though...

feat(html): implement complete Glimmer template syntax support

@coderabbitai full review

feat(html): implement complete Glimmer template syntax support

@coderabbit review

Implement proper deep merging for settings, env, and globals in config extension and overrides

CI Tests pass for me locally (macOS) so I'm not sure what's going on there. Looks like maybe just whitespace.

feat(js_parser): add Glimmer template support for .gjs and .gts files

@coderabbitai generate docstrings

feat(js_parser): add Glimmer template support for .gjs and .gts files

Hmm... didn't realize that CodeRabbit would make a new PR.

Update ApplicationInstance#visit to use followRedirects()

The router.js fix has finally landed. I've pushed the version update to this branch as well.

JSDoc `@import` no longer works correctly with default exports

@a-tarasyuk I have `allowJs: true` but no setting for `checkJs`.

Forbid accessing this.args in class-body space

Seems reasonable to me. Might want to discuss a bit more if we want it on by default.