ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

Update ApplicationInstance#visit to use followRedirects()

Open davidtaylorhq opened this issue 2 years ago • 3 comments

The current implementation of Transition#followRedirects() is identical to the logic here: it catches rejections, and then checks for any other activeTransition. Therefore, this commit introduces no change in behavior.

But, if/when https://github.com/tildeio/router.js/pull/335 lands, it will means we can take advantage of that fix for ApplicationInstance#visit.

davidtaylorhq avatar Nov 16 '23 11:11 davidtaylorhq

The router.js fix has finally landed. I've pushed the version update to this branch as well.

wagenet avatar Aug 02 '24 16:08 wagenet

Is anything blocking this?

wycats avatar Sep 05 '25 19:09 wycats

Tests were failing and it has not been updated since

kategengler avatar Sep 17 '25 17:09 kategengler