waacton
waacton
Update: issue has moved to https://github.com/JMdictProject/JMdictIssues/issues/136, doesn't look to be happening soon.
Thanks for the link, I'll keep it in mind. I hope there will be a summary because I don't have the energy to wade through hundreds of comments of debate...
Hmm, although I make a point in the readme of saying that "[performance is not a priority](https://github.com/waacton/Unicolour#-overview)", the performance you're describing is much worse than I'd expect and doesn't make...
I've been investigating with some profiling tools and I can't find anything concerning around reading the `Rgb255` values in this way, but I do see significant slowdown when I attach...
@otomad I'd be interested to know if running your WPF app without a debugger still has the same performance issues, because everything I've seen indicates it should be OK. I'm...
Constructor performance improvements have been merged in https://github.com/waacton/Unicolour/commit/dc70ed58f69c0910fab9a79f3591b204658ea1b7 and is available in [version 4.7.0](https://github.com/waacton/Unicolour/releases/tag/4.7.0) 🙂 With this change the constructor won't unintentionally trigger any calculations. And for further improvements you...
As a follow up to this, I've reworked how a `Unicolour` is constructed in 6.0.0, and some naive benchmark suggests it's 95% faster. Results for reference ``` BenchmarkDotNet v0.14.0, Windows...
There are a lot of moving parts to be considered! Similar to [CMYK](https://github.com/waacton/Unicolour?tab=readme-ov-file#cmyk) where ICC profiles are not restricted to 4 colour prints (e.g. CMYK vs CMYKOGV), I'll need to...
Ah excellent, that makes a bit more sense now, I'll take a look when I get a chance! There's also more detail about the _spectral.js_ implementation [here](https://github.com/rvanwijnen/spectral.js/issues/10#issuecomment-1828430254) but I'll need...
One more thing while it's on my mind: if this does lead to some notion of `Pigment` in Unicolour, it'd be _really_ convenient if it could be somehow generated from...