Andrey Rakhmatullin
Andrey Rakhmatullin
``` test/support/__init__.py:19: in import nntplib E ModuleNotFoundError: No module named 'nntplib' ``` nntplib was removed from Python in 3.13.
Some add-on tests use `"scrapy.core.downloader.handlers.http.HTTP10DownloadHandler"` as a sample non-default value. We deprecated that class in Scrapy recently so the tests should be updated, likely by using a locally defined handler...
A full test run is now about 20-30 minutes which is a problem for testing changes. I tried to investigate it and so far I've found that a single spider...
The annotations stuff is [significantly revamped in Python 3.14](https://docs.python.org/3.14/whatsnew/3.14.html#whatsnew314-pep649), I wonder if andi breaks with it, and we should try to add support for it not much later than it...
- [ ] Wait until Twisted supports 3.14 asyncio loop changes, is released and is supported by Scrapy - [x] Update `tests.test_squeues.PickleFifoDiskQueueTest.test_non_pickable_object()` - [x] Update `tests/CrawlerProcess/asyncio_enabled_reactor.py` - [ ] Update...
[Current docs](https://docs.scrapy.org/en/latest/topics/commands.html#custom-project-commands) only say "look at the existing ones", we could do better than that, at least by listing attributes you can access and override and functions you can override....
https://github.com/readthedocs/sphinx-hoverxref
It looks like sometimes `tests/test_commands.py::TestBenchCommand::test_run` hangs when run on Windows. Not sure if it's specific to any Python versions but locally I was able to quickly reproduce in on 3.9...
Until the Deferred counterparts are deprecated we should mention both, and I think not in the first list on the page but separately. `CrawlerRunner` / `AsyncCrawlerRunner` should already be mentioned...