Andrey Rakhmatullin

Results 123 issues of Andrey Rakhmatullin

There are several related things used by `HttpErrorMiddleware` and `RedirectMiddleware` (`handle_httpstatus_list` spider attr and meta key, `handle_httpstatus_all` meta key, `HTTPERROR_ALLOWED_CODES` and `HTTPERROR_ALLOW_ALL` settings), it would be nice to unify these,...

discuss
cleanup

This adds a new mode of running tests, one that disables pytest-twisted and enforces that there is no reactor. It doesn't use pytest-asyncio for now, instead skipping all async test...

enhancement
CI
asyncio

We deprecated almost all spider attrs used instead of settings, but `download_delay` is used to set the delay calculated by `AutoThrottle` so it can't be deprecated right now, but it...

cleanup

Preliminary release notes for master, to get an idea etc.

docs

I've seen a lot of user questions about `CrawlSpider`, most of them caused by its limitations. I'm biased but when asked I awlays reply "please consider not using it". In...

enhancement
docs
discuss

We should clarify https://docs.scrapy.org/en/master/topics/settings.html#special-settings based on the analysis in https://github.com/scrapy/scrapy/pull/6568#discussion_r1925145591 and ideally also make sure all affected settings themselves also say, or link, their specifics in their docs.

enhancement
docs

I think fixtures that check pytest marks and conditionally call `pytest.skip()` can be combined into one or two (one for the reactor, one for optional test deps?) and be some...

CI
cleanup

Can be done now for `process_item()`, but `{open,close}_spider()` use a `DeferredList` and so it's better to refactor that first

enhancement
asyncio

We have (and should make more) APIs that take both Deferreds and coroutines and wrap them in `deferred_from_coro()`, e.g. downloader middleware and pipeline methods. We should emit deprecation warnings if...

asyncio