Andrey Rakhmatullin
Andrey Rakhmatullin
urlsplit returns `'[2402:4e00:40:40::2:3b6]:80'` in `netloc` but `2402:4e00:40:40::2:3b6` in `hostname`, and safe_url_string uses this hostname value directly without putting it in brackets again. There may be some code in urllib that...
@himanshu007-creator sure, no problem with that
@HatimZ probably, but you need to make sure this code isn't called if `slot.start_exporting()` wasn't called (by reading the code, or maybe by making some test case). You'll also need...
If you mean a test case for making sure it's ohly called when start_exporting() was called it would just be a test spider with some exporter enabled and some different...
> Even if slot.finish_exporting() was called without the start being called, it wouldn't do anything because it checks for the flag/boolean set by start. Hence even if it gets called...
As both the pip issue and the test_engine deprecation warning issue have been fixed this is no longer needed.
This was included in #221.
We have a new probem now: as `drop_tree()` is only defined in HTMLElement, `drop()` doesn't work with the XML parser (so `Selector(type='xml')`, it raises `CannotDropElementWithoutParent` because `AttributeError` is raised from...
``` from parsel import Selector sel = Selector(text="", type='xml') el = sel.xpath('//b')[0] assert el.root.getparent() el.drop() ```
Makes sense to me. I also feel like this needs new tests, as the problem wasn't caught by existing ones. @Gallaecio you had some worries about supporting non-lxml parsers, do...