Vytautas

Results 9 comments of Vytautas

Since we are changing `.gen` already, a couple of considerations: - maybe choose `api` name instead - maybe rename `go` to `thrift`, that way we would get `gen/thrift` (or `api/thrift`)....

> Yeah, we could take this opportunity to rename. I think it's unavoidable that this is going to be a breaking change in some way - at the very least,...

I have been thinking about this for a bit in a context of migration to GRPC that we will need to do eventually. It basically boils down to the similar...

> So basically you'll have to expose some sort of API package, most probably from the cadence project itself. Yeah, that is the idea.

Reproduced. However this only occurs with return type of `interface{}`. Any other type works fine.

So there are actually two different issues: 1. When setting empty `[]byte` on workflow header via context propagator. The error only happens when using gRPC. And it was already fixed...

Thank you @longquanzheng for clarifications and detailed answers. Ok, I see that multiple key pairs is indeed required and may be useful in some cases. I'm not against it and...

Yes internal traffic is on gRPC by default already. For cross DC traffic, it need to be enabled like this: https://github.com/uber/cadence/blob/master/config/development_xdc_cluster0.yaml#L82 Yeah, that make sense. We will need to expose...

Are there any plans on merging this? This is very desired functionality when building kafka centric ingestion pipelines. We have tested this PR on our internal fork and it works...