Vyas Ramasubramani

Results 852 comments of Vyas Ramasubramani

@PointKernel this is another case where making progress on the unification of different cuco map types would be beneficial. If @ttnghia is getting the best performance with a CG size...

Binary operations in libcudf are designed so that nulls always propagate. As a result, although we have created a specialized mod operator `PYMOD` in libcudf for compatibility with Python's rules...

I'm fine with that explanation, although to @harrism's point we'd definitely need to document how we define remainder vs modulo since it's at best it's a nonstandard but common distinction....

@bdice @ttnghia I think this is ready for another round of review now. I believe that I've addressed the review requests.

> I wanted to post a couple nice links about Dremel encoding, since this is a core part of this PR. > > Summary of the encoding with nice diagrams:...

To summarize the results of our offline discussion: - We are going to push this PR to 22.10 to avoid any unforeseen performance implications for other code paths that are...

Here are the benchmarks results for sorting structs: Benchmarks ``` | NumRows | Depth | Nulls | Ref Time | Ref Noise | Cmp Time | Cmp Noise | Diff...