Volkan Yazıcı

Results 268 comments of Volkan Yazıcı

Note that `XmlSchemaTest` needs to be removed and its functionality should ideally be replaced with a `xml-maven-plugin` validation that can take place at the Maven `validation` phase.

Great work Piotr! :100: :clap: Some remarks: 1. I see many pages are hardly filled. Shall we collapse the entire reference to a single page? WDYT? That is, one page...

@shloim, the upcoming Log4j 2 release (i.e., `2.23.0`) will be the very first Log4j 2 version that ships Disruptor 4 support. (Disruptor 3 will still work too.) Is that something...

@shloim, can you give `2.23.0-SNAPSHOT` a try in combination with Disruptor 4? (See [docs on how to configure Maven/Gradle/SBT for snapshot builds](https://logging.apache.org/log4j/2.x/maven-artifacts.html#snapshot-builds).)

> Perhaps the [Log4j async manual](https://logging.apache.org/log4j/2.x/manual/async.html) could be more clear We can indeed do this. Updated the #2534 description accordingly.

@shloim, any updates? Were you able to reproduce the issue with Log4j `2.23.1` using Disruptor 4?

@jvz, the performance benefits of asynchronous loggers are extremely subjective to the deployment environment. Putting aside Log4j team itself is not able to reproduce [the (8 year old!) performance figures...

@AnushaGHerale, thanks so much for the report. We would really appreciate it if you can share a very very minimal example that we can use to reproduce the issue ourselves....

@takanuva15, sounds reasonable to me. I think both package exclusions and point matchers can coexist, there is no need to throw an exception when they do. Please take the following...

> @vy I tried accessing the Slack link but it says I don't have an account. Is there an account request-form somewhere that I need to submit? @takanuva15, I think...