Masahiro Wakame

Results 106 comments of Masahiro Wakame

I recommend to you use tsfmt.json in baseDir. Why do you want to use .editorconfig? If we support --baseDir option with .editorconfig, Editors can't pickup .editorconfig file from target dir....

umm... I feel like We can use .editorconfig with --baseDir together. Could you send a PR? BYW, tsfmt.json is typescript-formatter specific config file. It can use indentation settings. ``` {...

wait a moment. I'll ship it in 3 hours.

just released v4.2.0 and v5.0.0 😉

I'm working on https://github.com/vvakame/typescript-formatter/tree/fix-extends-tsconfig branch. Since there is no working time, it may be a little late to fix it.

just released v5.0.1. please check it! this issue is solved my local env.

umm.. I tried with your settings. But it is works. Now, tsfmt is using to parse tsconfig.json by typescript package. What version of tsc do you use? https://github.com/vvakame/typescript-formatter/blob/d688317d828f1a6363cf28bf6ad628586ea254ea/lib/utils.ts#L41-L61 ``` $...

> I expect semicolons to be added tsfmt uses compiler api of tsc. this behavior is not supported by tsc. I recommended to use `tslint --fix` option. https://github.com/palantir/tslint#cli-1 patched welcome!

What is the your expected behavior? `editor.tabSize` → `tabSize` ? `editor.insertSpaces` → `convertTabsToSpaces` ? tabSize is exists in `ts.EditorSettings` interface, but it is not used in tsfmt now.

when `convertTabsToSpaces: true`, tab char replaced by `indentSize: x` at current typescript implementation. I think if you want to use `"editor.insertSpaces": true`, use `"editor.indentSize": x`.