Vukasin Milovanovic

Results 139 comments of Vukasin Milovanovic

The introduction of the `host_mr` option would require substantial code changes to pass it to all places where the `hostdevice_vector`s are created. And this would still be limited the PQ...

Just measured the pinned memory peak use in the Parquet reader. In the benchmarks, which create tables with 512MB of data, the largest peak pinned memory use I saw was...

> But isn't 512MB much smaller than real world use cases? Sure, but the measurements show that pinned memory requirement are less than 1% of the device memory required to...

@etseidl I assume that the key-value pair is optional, but is it okay to include the key without the value?

This issue has been at least partially addressed. We need to make another pass over `CompactProtocolReader::read` functions to verify that all optional fields are treated as such.

This makes sense to me. Sounds beneficial even if we don't apply the pattern to all kernels. Could you help me understand the following? > The rle_stream class uses shared...

The decode kernel does not detect the error, `page_state_s.error` flag stays at zero when reading the linked file. If this flag was raised, we could use it to communicate the...

There seems to be a bug in `decode_page_data`, which causes double allocation of the nested string column. Somehow two `out_buf` objects allocate string data based on the same `src_col_index`. This...