Vukasin Milovanovic
Vukasin Milovanovic
/ok to test 6708c96
Hi @JigaoLuo, thank you for this patch! I'm working my way through the changes. Have you seen any performance impact from these changes?
AFAIK compute-sanitizer won't help us find the issues with host object going out of scope because we removed a sync point. I'm not sure we should replace all without examining...
> It may help to investigate these errors with https://docs.nvidia.com/compute-sanitizer/ComputeSanitizer/index.html#stream-ordered-race-detection: `compute-sanitizer memcheck --track-stream-ordered-races all` Thought about this a bit more. The scenario I was concerned with is when we use...
@GaryShen2008 Thank you for opening the issue Could you please clarify what the content of the `test.csv` is? I could not find this in the issue.
I can't repro this issue. The following test passes: ``` TEST_F(CsvReaderTest, ReadCsvWithLtQueryAndLastTs) { auto filepath = temp_env->get_temp_dir() + "lt_query_last_ts.csv"; { std::ofstream outfile(filepath, std::ofstream::out); outfile
> Relatedly I think, like @harrism, that eagerly releasing/reallocating a bounce buffer on every resize is probably a pessimisation. You might be updating the device data and not intend to...
I wonder if we want a builder API, so we don't need a constructor for every combination of resources, or default params for new members, as we add resources to...