Vincent Traag

Results 160 comments of Vincent Traag

I've now updated the docs. By the way, I'm not sure how the deprecation should be dealt with in the docs? Should the old argument still be there, saying it's...

Feeling like a complete n00b again! Now get `Error: Error in deprecated() : argument "old" is missing, with no default` in the CI. According to the docs `deprecated` doesn't have...

Can we for now use `lifecycle::deprecated` ? What is the `igraph::deprecated` function used for, and do we need to retain it at all? (Separate PR and/or issue might be good...

Your proposed names sound good to me, assuming your descriptions of these functions are indeed accurate (which I did not double check). If possible, I would then also remove the...

Hmm, that's strange indeed. In principle the runtime shouldn't be that much different with or without fixed membership (and in fact a bit faster when some memberships are fixed). Do...

Thanks for the code. But I'm not sure if I understand the problem. With the fixed membership, the runtime of `leidenalg` is about 3 times faster than without, no? The...

I'm closing this because there is no concrete action to take for the `leidenalg` implementation. For pure speed, the `igraph` implementation will indeed be faster, but offers less flexibility.

Apologies for the late reply. This is not implemented indeed, only the `diff` output provides that "total" multilayer modularity score, in terms of the improvement. That is, `diff` provides the...

Instead of adding an argument to these functions, could it perhaps be handled more gracefully by simply returning whatever results are already found when the function is interrupted? This also...

Just my 2 cents: I would not implement anything like this for 1.0. This seems to involve quite some tricky situations that would need to be carefully considered. More generally,...