Vilen Topchii
Vilen Topchii
Currently, v48.0 Salesforce API during [PATCH by external ID](https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/dome_upsert.htm) returns 200 on a successful update, with next payload: ``` { "id": "001D000000IqhSLIAZ", "success": true, "errors": [], "created": false } ```...
**Version:** [v4.9.5](https://github.com/mailgun/holster/releases/tag/v4.9.5) ``` WARNING: DATA RACE Write at 0x00c00006c0f8 by goroutine 16: github.com/mailgun/holster/v4/clock.(*frozenTime).unlockedStartTimer() github.com/mailgun/holster/v4/clock/frozen.go:151 +0x211 github.com/mailgun/holster/v4/clock.(*frozenTime).startTimer() github.com/mailgun/holster/v4/clock/frozen.go:133 +0xa4 github.com/mailgun/holster/v4/clock.(*frozenTime).AfterFunc() github.com/mailgun/holster/v4/clock/frozen.go:50 +0x1db github.com/mailgun/holster/v4/clock.(*frozenTime).NewTimer() github.com/mailgun/holster/v4/clock/frozen.go:[38](https://github.com/mailgun/holster/actions/runs/3740540806/jobs/6349033540#step:7:39) +0x38 github.com/mailgun/holster/v4/clock.(*frozenTime).Sleep() github.com/mailgun/holster/v4/clock/frozen.go:30 +0x[39](https://github.com/mailgun/holster/actions/runs/3740540806/jobs/6349033540#step:7:40) github.com/mailgun/holster/v4/clock.Sleep() github.com/mailgun/holster/v4/clock/clock.go:76 +0x37...
There are a few pending changes for v5: https://github.com/mailgun/holster/search?q=TODO%28v5%29
``` === RUN TestNewClientTLS config_test.go:26: Error Trace: /home/runner/work/holster/holster/consul/config_test.go:26 Error: Received unexpected error: Put "https://127.0.0.1:8501/v1/kv/test-key-tls": x509: certificate has expired or is not yet valid: current time 2022-12-20T12:40:42Z is after 2021-11-18T22:57:23Z Test:...
``` === RUN TestGetSRVAddresses srv_test.go:56: Error Trace: /home/runner/work/holster/holster/discovery/srv_test.go:56 Error: Received unexpected error: lookup mll.scout.service.consul on 127.0.0.53:53: no such host Test: TestGetSRVAddresses --- FAIL: TestGetSRVAddresses (0.08s) ``` https://github.com/mailgun/holster/actions/runs/3740540806/jobs/6349033540
Fix test/code or deprecate and switch to [built-in package errors](https://pkg.go.dev/errors). ``` === RUN TestFormatGeneric format_test.go:476: test 1: block 6: fmt.Sprintf("%+v", err): got: "github.com/mailgun/holster/v4/errors.testGenericRecursive\n\tgithub.com/mailgun/holster/v4/errors/format_test.go:504\ngithub.com/mailgun/holster/v4/errors.testGenericRecursive\n\tgithub.com/mailgun/holster/v4/errors/format_test.go:523\ngithub.com/mailgun/holster/v4/errors.testGenericRecursive\n\tgithub.com/mailgun/holster/v4/errors/format_test.go:523\ngithub.com/mailgun/holster/v4/errors.testGenericRecursive\n\tgithub.com/mailgun/holster/v4/errors/format_test.go:523\ngithub.com/mailgun/holster/v4/errors.TestFormatGeneric\n\tgithub.com/mailgun/holster/v4/errors/format_test.go:359\ntesting.tRunner\n\ttesting/testing.go:1446\nruntime.goexit\n\truntime/asm_amd64.s:1594" want: "github.com/mailgun/holster/v4/errors.(func·002|TestFormatGeneric.func2)\n\t.+/errors/format_test.go:333" all-got: new-error github.com/mailgun/holster/v4/errors.TestFormatGeneric github.com/mailgun/holster/v4/errors/format_test.go:315 testing.tRunner...
``` === RUN TestSrvResolverBuilderSuccess ================== WARNING: DATA RACE Read at 0x00c0003322a8 by goroutine 43: github.com/mailgun/holster/v4/discovery_test.TestSrvResolverBuilderSuccess() /Users/vtopc/mailgun/holster/discovery/grpc_srv_resolver_test.go:82 +0x9f7 testing.tRunner() /usr/local/go/src/testing/testing.go:1446 +0x216 testing.(*T).Run.func1() /usr/local/go/src/testing/testing.go:1493 +0x47 Previous write at 0x00c0003322a8 by goroutine 46:...
`Error: Codecov token not found. Please provide Codecov token with -t flag.`