Nathan Moore
Nathan Moore
- [Requirements](https://github.com/NREL/OCHRE/blob/main/setup.py#L10) should be versioned, ideally using [compatible versioning](https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release). - [Python](https://github.com/NREL/OCHRE/blob/main/setup.py#L57) version should be restricted too, to not pick up development versions. - For instance, due to a numba restriction,...
#### Any background context you want to provide? Level 1 (reading from a sys-param file) only for a steam example. #### What does this PR accomplish? - Adds new parameters...
### Expected Behavior We should seamlessly (from the user's perspective) create 5G systems that aren't GHE. We haven't yet supported waste heat via the CLI. ### Actual Behavior https://github.com/urbanopt/geojson-modelica-translator/blob/develop/geojson_modelica_translator/system_parameters/system_parameters.py#L734-L739 does...
### Expected Behavior We should be able to run our full test suite with CI on Windows ### Actual Behavior Some paths don't work properly. Local testing has worked but...
### Expected Behavior To be able to pick & choose buildings from my geojson file to include in simulation ### Actual Behavior Using less than all buildings leads to incorrect...
### Expected Behavior Tests should not duplicate effort, but also not silently require other tests to have already run. \ We could use [PyTest fixtures](https://docs.pytest.org/en/6.2.x/fixture.html) to call other tests and...
### Expected Behavior Now that 5G models are implemented, we should ensure our starting values are appropriate for those models and not holdovers from 4G models. ### Actual Behavior
### Expected Behavior We now have models that will only work with a given generation of district system. We should arrange the file structure to make it clear which are...
https://github.com/urbanopt/geojson-modelica-translator/blob/develop/geojson_modelica_translator/system_parameters/system_parameters.py#L148 Two options: 1. Remove all handling of default values, since they no longer exist in the sys-param file 1. Read default values from schema
**Is your feature request related to a problem? Please describe.** AWS Cloud Formation does the role creation that we do manually, except it's native to AWS and isn't prone to...