Viktor Szakats

Results 46 issues of Viktor Szakats

Macro and static function names were colliding between `lib/md4.c` and `lib/md5.c`. Fix it by namespacing these symbols. Seen with a basic macOS build using these options: `-DCMAKE_UNITY_BUILD=ON -DCURL_USE_SECTRANSP=ON` Closes #13737

cmake
cryptography

`CURLDEBUG` is meant to enable memory tracking, but in a bunch of cases, it was protecting debug feature that should be guarded with `DEBUGBUILD`. Replace these uses with `DEBUGBUILD`. This...

build
cmdline tool
tests
libcurl API
CI

These macros also enable debug features in both libcurl and curl. Enable `VS_FF_DEBUG` resource flag when they are set. Closes #13730

cmdline tool
Windows

It affected cmake-unity shared-curltool curldebug mingw-w64 gcc builds when building the `testdeps` target. Apply the solution already used in `lib/base64.c` and `lib/dynbuf.c` to fix it. Also update an existing GHA...

cmake
tests
Windows
CI

For the first time in CI I enabled WebSockets in a native Windows job with tests, where ~~2305 fails consistently~~, 2301 and 2302 failed once each (so far): - ~~https://github.com/curl/curl/actions/runs/9133449443/job/25116951463#step:14:14502...

tests
Windows
WebSocket

Follow-up to a86254b39307af1a53735b065a382567805cd9b8 #12515 Closes #13713

build
cmake
appleOS

Closes #13711 --- Without whitespace changes: https://github.com/curl/curl/pull/13711/files?w=1

build
cmake
cmdline tool
tests
tidy-up

Before this patch, building unit tests (= the `testdeps` target) required `-DCURLDEBUG` be set either via `ENABLE_DEBUG=ON` or `ENABLE_CURLDEBUG=ON`. After fixing the build issues in #13694, the above requirement is...

build
cmake
tests

Changing this output: ``` TESTFAIL: These test cases failed: 2301 2303 2302 2307 ``` Ref: https://github.com/curl/curl/actions/runs/9228638364/job/25393106631#step:6:21181 To: ``` TESTFAIL: These test cases failed: 2301 2302 2303 2307 ``` Cherry-picked from...

tests
script

- `websocket.c`: use `Sleep()` on Windows. `sleep()` and `unistd.h` are not available in MSVC. - `http2-upload.c`: use local `gettimeofday()` implementation when compiled with MSVC. (Alternate solution is to disable the...

cmake
documentation
Windows