Viktor Szakats

Seen when setting `ENABLE_DEBUG=ON` and `-DDEBUGBUILD` for mingw-w64 gcc 13.2.0 CMake unity builds in 'Release' configurations. ``` curl/lib/curl_gethostname.c:71:5: error: 'strncpy' specified bound 1025 equals destination size [-Werror=stringop-truncation] 71 | strncpy(name,...

TFTP tests fail on OpenBSD (ci/GHA)

5

### I did this While adding an OpenBSD job (with tests) to GHA, some tests failed to run: - 271 283 284 285 286 332 1007 1009 1093 1094 1099...

GHA: add NetBSD, OpenBSD, FreeBSD/arm64 and OmniOS jobs

11

Add these jobs to GHA: - NetBSD, cmake-unity, clang, OpenSSL, x86_64, with tests, w/o python, no parallelism (was flaky sometimes) - OpenBSD, cmake-unity, clang, LibreSSL, x86_64, with tests, with python,...

libssh2: also try `fopen()` when looking for implicit keys

4

Replace `stat()` calls with `fopen(.., FOPEN_READTEXT)`, which is how libssh2 opens these files at a later point. Follow-up to 602fc213aeda9e9bb2879143942d850e000b2ea6 #13498 Bug: https://github.com/curl/curl/commit/602fc213aeda9e9bb2879143942d850e000b2ea6#r141676880 Reported-by: Harry Sintonen Closes #13571 --- /cc...

Also add a couple of negative checks. Cherry-picked from #13489 Closes #13622

Cherry-picked from #13489 Closes #13614

compiler warnings with LibreSSL 3.7.3 (gcc 9, macOS, mingw-w64)

9

``` gcc 9: ../../crypto/x509/x509_addr.c:732:9: warning: 'afi' may be used uninitialized in this function [-Wmaybe-uninitialized] mingw-w64 llvm 16 when built against curl (8.2.1): ../../libressl/x64-ucrt/usr/include/openssl/ossl_typ.h:90:2: warning: #warning is a C2x extension [-Wpedantic]...

3.8.2 gcc 13 warnings `-Wstringop-overflow`, `-Wdangling-pointer`

7

``` In function 'make_kn', inlined from 'make_kn' at ./libressl/crypto/cmac/cmac.c:80:1, inlined from 'CMAC_Init' at ./libressl/crypto/cmac/cmac.c:191:3: ./libressl/crypto/cmac/cmac.c:92:28: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 92 | k1[bl -...

Controlling visibility of ASM functions

7

I'd like to limit visibility of non-exported LibreSSL functions. For C functions this is doable with `-fvisibility=hidden`. For ASM functions however, llvm/gcc don't offer a built-in command-line option. For macOS,...

build: untangle `UNITTESTS` and `DEBUGBUILD` macros

6

- fix `DEBUGBUILD` guards that should be `UNITTESTS`, for libcurl code used by unit tests. - fix guards for libcurl functions used in unit tests only. - sync `UNITTEST` attribute...