Vitalie Spinu comments

Results 368 comments of


                                            Vitalie Spinu

`use_z_format` argument added to `format_ISO8601()`

Thanks, but this PR has a lot of white-space changes and it's dificult for me to judge what is actually changed. Regarding the name, would it be ok to use...

`use_z_format` argument added to `format_ISO8601()`

There are failures. Hadley is working on a new workflow, hopefully those are gone once done. Will merge this one once that works has been done.

Adding parsing support for weeks

This issue is not well defined. Could you please state precisely the functionality that you would like to see in lubridate with concrete code examples?

Adding parsing support for weeks

In simple words, do you want to be able to parse weeks (US, ISO, EU)? Aka, be able to parse %V, %U and %W formats? As in: ``` parse_date_time(c("2015-52", "2015-53"),...

Adding parsing support for weeks

It should be straightforward addition to the internal parser, and should work the same on all platforms. System's strptime is known for buggy/inconsistent parsing of partial date-times.

Problem with Ukrainian locale month names

Could it be that your system names November something different than `листопада`? What is the result of `lubridate:::.get_locale_regs()$month_names` in your locale?

Problem with Ukrainian locale month names

@YevhDr Could you please post here?

Problem with Ukrainian locale month names

Thanks. It's `листопад` instead of `листопада`. This screws the inference. I will think of a workaround.

Update testthat style

Sound like an over-engineering to me. We already have a lot of test files and having yet another 12 just for settors doesn't seem right. There are advantages to keeping...

parse_date_time adds 1s extra if second has fractional component (only on MacOS)

This one is peculiar. This parsing is (should be) happening at C level.