Vaibhav Singal

Results 35 comments of Vaibhav Singal

Or maybe add `all` to `must_include` in changeset. I see that `must_include` option processor supports functionality of `all` already. It's just that input setting of `changeset` does not expose that.

``` - when: pull_request.*, pull_request_review.* name: 'Some PR check' validate: - do: or validate: - do: changeset must_exclude: regex: 'src/main/resources/views/([0-9A-Za-z]+/?)+' - do: changeset and: - must_include: regex: 'src/main/resources/views/([0-9A-Za-z]+/?)+' - must_exclude:...

Using `limit` might get redundant I guess as we would be copy pasting same regex in most cases I can think of What say, let's give `all` a shot? I...

Also I want to perform an action when the second `changeset` option in `or` is fulfilled. Is that possible? Current doc says that we can have actions on overall success...

``` - when: pull_request.*, pull_request_review.* name: 'Some PR check' validate: - do: or validate: - do: changeset must_exclude: regex: 'src/main/resources/views/([0-9A-Za-z]+/?)+' - do: changeset must_include: regex: 'src/main/resources/views/([0-9A-Za-z]+/?)+' all: true ``` This...

> For now, i think you can have a second recipe that only include the individual constituents you want and have an action for the second recipe. But that would...

@shine2lay I saw some weird behaviour. When I added `all` to `must_include` under `changeset`..it **worked**. Out of the box. Despite the fact that `supportedSettings` of `changeset` validator does **not** support...

To clarify (don't have much experience in node based apps) - 1. re install the node packages -> means running `npm install` or `yarn --ignore-engines` .. right? 1. use the...

1. I updated `.nvmrc` to use `12.20.1` 2. I didn't update `engines` field in package.json One question, mergeable uses `14.15.4`. Will it work with `12.20.1` if i use one? Currently...