Vinay Sajip

Results 94 comments of Vinay Sajip

Before saying what the solution should be, I'd rather know more about the problem - namely, under what circumstances do the results of the two libraries differ? That would perhaps...

> The module constant (and signal use) seems like overkill to me. > Why not just find the partial by name when requested, making it a cached property if needed?...

OK, removed caching, including the global map. > (I'm not seeing why we need the global map) For performance on large templates with lots of partials (saves having to scan...

I changed the finder function to this, looking for a specific partial: ```python def find_partial_source(self, full_source, partial_name): """ Search the full source of the template, looking for the sought partial...

It's an HTMX application, and the test view extends the basic layout to display a specific component or two being tested. The basic layout contains a lot of components in...

I would prefer separate stubs, at least for now, as the package still supports Python 2.x.

That seems more reasonable - by all means propose a `.pyi` file with typing information, and I'll aim to keep that updated with any API changes. I'm not too familiar...

I'd find it hard to implement and test this as I don't have a smart card setup, but I'll look at a PR to add this functionality.

I think a more generic approach is needed - for example `csrf_token` ought to be passed too, else the `{% csrf_token %}` in a component will render as empty. Probably...

Oh, I'm using these changes locally. I don't think this project's maintainer has the time to work on it now.