Marcos Cardoso

Results 11 comments of Marcos Cardoso

Humm change the parameters' order may lead to broken builds by anyone using this method. Do you think that this change still worth? If yes, wdyt of create a new...

Humm, good point. Do you still think that we should merge it even knowing that this is a breaking change? Maybe we can do it but add a warning on...

It seems that **MUST** and **SHOULD** are already implemented, but *MUST_NOT** is not (See [here](https://github.com/vrcmarcos/elasticmock/blob/master/elasticmock/fake_elasticsearch.py#L30-L32)). It seems an easy change, afaik. Wdyt of sending a PR with that?

Humm good point! Do you mind to send a PR with that change?

Hi @jonatak , ty for your comment! Do you mind to send a PR with this improvement?

Humm I'm not too much into this library right now, just coordinating PR and releasing new versions. If this approach works for your use case without breaking any existent test,...

Sorry guys, but I do not have too much time to maintain this library. But you can always send a PR with this improvement :)

I'm not actively developing this library anymore. We have a few people here adding features, but feel free to send a PR with that improvement! Wdyt about that? It may...

I don't believe that someone has sent a PR adding this feature, but it would be awesome if you could do it 😀