Victor Vu

Results 204 comments of Victor Vu

Your original way isn't wrong. Unfortunately, `take` is broken when combined with `fork` but can't be fixed in 2.x for back-compat reasons. Basically, `take` still exerts backpressure even after it's...

Yes, that's seems about right. Using a singleton queue and `stream#write`to append is how I would do it.

Closing this. Feel free to reopen if you have other questions.

Sorry about that. I didn't realize Github doesn't let you reopen issues that someone else closed. That's pretty silly. To answer your questions > In both the `createBuildStream` and `createTestStream`...

`parallel` does respect backpressure in the sense that it will not call `write` until the node stream asks for it, and it will attempt to consume inner streams until it...

I think the weird falsy value behavior is from the `PassThrough`stream. See [this part](https://github.com/nodejs/node/blob/master/lib/_stream_transform.js#L76) from the implementation of `Transform`where a data item isn't passed through if it is `null`or `undefined`....

Note that there's nothing backpressure can help you with if you're throwing all of the values away like this. There's no way downstream consumers can know to pause their sources...

This is a bug in 2.x, but it seems complicated to fix, and I don't have a lot of bandwidth to chase this down (the 2.x core has a lot...

The `master` branch has a partial implementation of `destroy` propagation if you'd like to look into it more. Search for `onDestroy`. The changes there should correctly handle the bug you...

I'm also a weak +1, but for the reason that this sentence is not meant to be an exhaustive list of all methods that consume a stream---that's what the [Consumption...