Vratislav Podzimek

Sanitize modules/zram/udiskszramutil.c:set_conf_property()

1

This function is gross.

Refactor udisks_linux_block_handle_format()

1

We should not have a 600+ lines long function. [1] [1] https://github.com/storaged-project/udisks/blob/master/src/udiskslinuxblock.c#L2870

udisks(-zram) installs a udev rule plus a systemd service that are dangerous

3

There's the following rule in *data/80-udisks2.rules*: ``` # Zram devices setup KERNEL=="zram[0-9]", ENV{SYSTEMD_WANTS}="zram-setup@zram%n.service", TAG+="systemd" ``` and this is what the [email protected] does: ``` [Service] Type=oneshot RemainAfterExit=yes EnvironmentFile=-/usr/lib/zram.conf.d/%i-env ExecStart=-/bin/sh -c 'echo...

Method calls not fully synchronous

16

If a method that results in objects' properties being changed is called, the call finishes while the properties are still being updated by the ["udev feedback loop"](https://github.com/storaged-project/udisks/issues/572#issuecomment-421935724). So in some...

Only respect 'ifelapsed' if there is a previous promise evaluation

1

If the promise is being evaluated for the first time (no records in the locks LMDB), it doesn't make sense to check 'ifelapsed' for it.

A few LMDB related fixes

1

Goals: - [x] fix potentially unaligned access to LMDB data in *cf-check* - [ ] add `--test-write` to `cf-check repair` - [ ] handle full LMDBs

rename program.log to external.log

4

Now that _libblockdev_ may use DBus for LVM instead of running binaries it may log DBus calls instead of information about spawning processes. Thus `external.log` is a more appropriate name...

For example in #350, new enum values are added. Which means ``BD_NVDIMM_NAMESPACE_MODE_UNKNOWN``, which should logically be last, now is a different integer value which is an ABI change. We should...

This is quite crucial in cases where there are two or more VGs with the same name. Like for example in the case addressed in https://github.com/storaged-project/blivet/pull/652

Instead of the ``dmsetup`` utility.