Vít Ondruch

Results 259 comments of Vít Ondruch

Yes, thx for referencing it here. I wanted to open a ticket in Redmine, but I still have not done all the testing I would love to do :see_no_evil: especially...

BTW I still think that something like the `UnpackedInstaller` should belong to Rubygems/Bundler. But since I don't think I'll be able to work on such feature anytime soon, I just...

The ruby/ruby#2545 is red just because of some random GC failure on Windows. I cannot imagine there would be any relation to my PR. This one is red due to...

Rebased, but there is not one issue I need to investigate :disappointed: ~~~ 1) Failure: TestGemInstaller#test_install_creates_binstub_that_prefers_user_installed_gem_to_default [/home/runner/work/rubygems/rubygems/test/rubygems/test_gem_installer.rb:1013]: default gem's executable not installed. Expected path '/tmp/test_rubygems_3049/gemhome/bin/executable' to exist. ~~~

Not sure what are the test failures. They do not seems to be related :man_shrugging:

I think that the `TestGemCommandsInstallCommand#test_execute_rdoc_with_path` issue is due to RDoc 6.2.0 and https://github.com/ruby/rdoc/commit/6e78ab0eba2ebbe4ed2bc4f4e8b3efc9823a452e or RDoc 6.2.1 should fix it. IOW `Gemfile.lock` should be refreshed. Nevertheless, why is the `Gemfile.lock` stored...

Given the #5043, maybe I should dustoff this attempt ...

While this was workaround in #288, I think this is superior fix.

I think the issue is that the test suite is executed this way: ~~~ $ ruby -I.:lib -e 'Dir.glob "test/**/*_test.rb", &method(:require)' ~~~ Given the test file names, no wonder there...

But this might be also given the test restructuring in 0.9.4 ¯\_(ツ)_/¯