Marcin Ignac

Results 167 issues of Marcin Ignac

For [buster drone](https://sketchfab.com/3d-models/buster-drone-294e79652f494130ad2ab00a13fdbafd) there is only 3 materials and 10 textures but in the current code: - handleMaterial is called 40 times - getPexMaterialTexture is called 38 times - ctx.texture2D...

type/feat

Currently we can set `material.vert` and `material.frag` but that breaks as we also include them in the depth prepass shaders `vert: material.vert || DEPTH_PASS_VERT`. The correct (needs testing) way is...

type/feat

Currently all cameras are rendered all the time if enabled [index.js#L1158](https://github.com/pex-gl/pex-renderer/blob/master/index.js#L1158) ```javascript cameras .filter((camera) => camera.enabled) ``` Sometimes it would be useful to have 2 or more cameras and switch...

needs-review
type/feat

We always needed one and will even more sooner or later. General approaches I can thing of: Core - Using pex-gui is currently not possible as we are missing tree,...

needs-review
type/feat

Clarify use of [D_GGX](https://github.com/pex-gl/pex-renderer/blob/master/shaders/chunks/brdf.glsl.js#L8) and [F_Schlick](https://github.com/pex-gl/pex-renderer/blob/master/shaders/chunks/brdf.glsl.js#L25)

type/feat

Different names are used in different places causing differences in e.g. D_GGX and MicrofacetDistribution which should be merged.

type/feat

https://github.com/pex-gl/pex-renderer/blob/master/point-light.js#L49 ![Screenshot 2019-05-03 at 13 39 07](https://user-images.githubusercontent.com/171001/57137825-df4fe800-6da8-11e9-90bb-877e4713baa7.jpg)

type/feat

Default Uncharted2 ![screen shot 2019-03-07 at 18 06 53](https://user-images.githubusercontent.com/171001/53945022-facda800-4103-11e9-9dcb-795539e85ed0.jpg) ACES ![screen shot 2019-03-07 at 18 07 45](https://user-images.githubusercontent.com/171001/53945028-fef9c580-4103-11e9-94ae-4cfc38067775.jpg) It's not only much more saturated but also much brighter? (check gamma) ```glsl...

needs-review
type/feat

needs-review
type/feat
type/perf

The question how to export Component class for external usage brings questions on how other libraries do it ```javascript const { vec3 } = require('pex-math/vec3') const { add: add3 }...

question
needs-review
type/feat