Michael Vorburger

Results 604 comments of Michael Vorburger

Whoa... wait, I spent some time to dig into the code (`UsingGet[Localized]Message`, `UsingGet[Localized]MessageTest` and `ManualMessageDetector`), and found out that in #31 there was work to intentionally only flag this as...

@KengoTODA can the Detectors be made configurable (how, example?), or would it be simpler to just have two separate detectors / bug patterns for enforcing the getMessage() with/without cause style?

@maggu2810 yeah it seems like there are clearly different requirements in different projects. So how would you (and @KengoTODA) feel about it if I simply proposed an additional detector named...

> I don't care as long as it is optional do you happen to know how to make a Detector excluded by default? > forbid it for logging only or...

@KengoTODA would you welcome (and merge) a PR for this?

@seanf just FYI I'm holding further comments & contributions to this project until my #72 moves. I can only encourage you to raise a PR yourself for a check like...

@ZaxonXP I initially also struggled a little bit to figure out what's where, so I wrote up the steps on http://blog2.vorburger.ch/2018/07/how-to-bulk-upload-old-photos-to-google.html so that I remember next time I use it...

@KengoTODA do you have any plans to add this, or would you welcome a PR with this?

@KengoTODA this fails locally for me with this message, which makes no sense to me, can you help: ``` ------------------------------------------------------------------------------- Test set: jp.skypencil.findbugs.slf4j.UsingGetStackTraceTest ------------------------------------------------------------------------------- Tests run: 1, Failures: 0, Errors:...

@KengoTODA I've written the test differently in the 3rd commit (like the existing ones), so now it passes.