Smit Vora

Results 13 comments of Smit Vora

I am against the requirements of this feature for the following reasons: - The posting date is a date when accounting effect is required - This is editable from when...

### Before ![is_default-user_perm-before](https://github.com/frappe/frappe/assets/10496564/d4a62a3c-87ad-4405-85b5-1a1692d448b9) ### After ![is_default-user_perm](https://github.com/frappe/frappe/assets/10496564/053b9722-84d3-49bd-af49-bfcc42cb54e4) It will set the default value only if checked. Else it wouldn't set the default value.

Hi, This seems to be causing the error. https://github.com/frappe/frappe/pull/20900/files#diff-93805dde1abe4b5b9587e5c4dd1a820183d5c54a89fd8168b65c03c737637fd2R132 Tests Failing: https://github.com/resilient-tech/india-compliance/actions/runs/4899967262/jobs/8752991601?pr=647#step:12:78 `address_dict` can also be of NoneType.

@phot0n, this works. thanks. > just don't invoke that function call :P We use ERPNext APIs, and they use this API, which caused the error 🤣

@agritheory, Can you share some examples? Following is what I could best think of. ## Proposal 1 ### Make account type extensible Account Type is used for multiple scenarios and...

'validate_payroll_payable_account(self)'

It's recommended to process all GST Transactions through sales or purchase invoice. In my opinion you are looking for a simpler interface to book expenses. Journal Entry is not designed...

@shubhampreciholesports, Following docs could be useful in how this came up. https://docs.indiacompliance.app/docs/configuration/purchase_transaction#itc-ineligibility