openlayers-timeline icon indicating copy to clipboard operation
openlayers-timeline copied to clipboard

Merge gh-pages branch

Open ZiglioUK opened this issue 13 years ago • 5 comments

Maybe we could remove the master branch and keep just gh-pages, what do you think?

ZiglioUK avatar Dec 07 '11 20:12 ZiglioUK

I'd like to fix the bugs we're discussing before merge to gh-pages so we release a stable demo and not a bleeding edge one. Do you agree?

volpino avatar Dec 11 '11 11:12 volpino

That's fine with me, I didn't have clear what the roles of 'gh-pages' and 'master' should be. Also I didn't realize I had a small error: timeline.js:249 Uncaught ReferenceError: past_seconds is not defined

  1. Not too sure in javascript what it does declaring a variable at the begin of a function followed by comma. I thought perhaps it would declare a variable with var scope but that doesn't seem to work
  2. Have never really understood what this piece of code is for: if (past_seconds - firstdate > 0) { $(this.slider).slider("value", Math.ceil(((past_seconds - firstdate) / (this.current_date - firstdate)) * 100)); }

ZiglioUK avatar Dec 11 '11 20:12 ZiglioUK

Oh, I see you've already fixed the error at line 249! cheers

The code: if (typeof console == "undefined" || typeof console.log == "undefined") console = { log: function() {} };

was there because I noticed the object console wasn't available on all browsers

ZiglioUK avatar Dec 11 '11 21:12 ZiglioUK

gh-pages branch is published on http://volpino.github.com/openlayers-timeline/

I removed all the console.log because they are only for personal debugging and should not be in the repo.

That piece of code actually i think it's not used already but it's useful if there's the need to start the slider from an arbitrary date. for example: http://sonetlab.fbk.eu/wikitrip/#|en|James%20K.%20Polk|1178192008|1 (i wrote all this code for that project and then i extracted a more general library that should be included in that project too)

volpino avatar Dec 11 '11 21:12 volpino

Very impressive work! I see you set the timeline from a date past the beginning.

Another project I've been working on (but not for a while) has been making the Google Earth plugin work with OpenLayers: https://github.com/ZiglioNZ/GoogleEarth-for-OpenLayers/blob/master/GoogleEarth-for-OpenLayers/src/googleearthforol.js

I need to fix it to make it work with the cluster strategy.

ZiglioUK avatar Dec 11 '11 21:12 ZiglioUK