Christopher Field

Results 60 comments of Christopher Field

See also #112 for more information.

I wonder about the interplay between the `-p,--package` option and the `` positional argument. What if both are used for the same package manifest? Does the existence of the ``...

Supporting multi-crate workspace project has never occurred to me! Thanks for the feature request and making me aware. >I ended up with `cargo wix -n myapp --install-version 0.0.1` to get...

Thank you for sharing your project. It will be useful as a template to implement better support for workspace projects. >I see the point about the virtual and non-virtual workspaces,...

I still do not have a clear picture of how to implement workspace support given the above discussion, questions, and variety of project layouts. [After reviewing some discussion on workspaces...

Hmm, I looked at your [airshipper](https://github.com/Songtronix/Airshipper) project. Is it possible to move the `wix` folder from the root project directory to the `client` directory and then have the CI execute...

>I've tested moving the wix folder into client and it looks like this works perfectly and removes the renaming bit and explicitly stating the version, thanks! @Songtronix Great! I am...

Would a combination of the `cargo wix -o ` option and positional argument eliminate this annoyance? For example, from the workspace root folder: ```dos cargo wix -o target\wix\ client\wix\main.wxs ```...

Ah, `cargo-wix` when called from the workspace root is looking at the virtual manifest, `Cargo.toml`, and not the package manifest, `client\Cargo.toml`. The virtual manifest does not have the `name` field....

Workspace support might be supported with the new implementation that resolves #70 as of 4cf7cc0584a6d7f5cad29cfaf1b7aa4c3432ee28. A path to the client's Cargo.toml file could be used and the installer should be...