Christopher Field

Results 60 comments of Christopher Field

Added documentation and information about the CRT dependency and static linking as of bc06cb856f603a661050d9cc118bb71f973458bb. This does not implement any resolution of the issue but it does resolve the original description...

I was experimenting with adding detection of the `+crt-static` compiler feature to at least notify/warn the user this might be an issue he or she needs to manually address/resolve. It...

I tried refactoring the `run` method for the `Execution` type in the `create` module following the idea from https://github.com/volks73/cargo-wix/pull/129#issuecomment-730471302. It is not really going to work because the linker/light command's...

Any listed `target_feature` might be useful as well, i.e. `crt-static` (#115). I guess each one would become `TargetFeature`. If set, then it will be defined. If not set or present...

As of 8448e17199d3d4076c39e11a9bd72ae7d14784fb, the `TargetEnv` and `TargetVendor` WiX variables are available at least. The `TargetFeature` variables are still a work-in-progress.

>* `CARGO_CFG_`: Can be acquired with `cargo --print cfg`. See #126. Just a minor correction in case someone finds this issue. It is the `rustc --print cfg`, not `cargo --print...

In summary, the only Cargo variable of interest is the `CARGO_FEATURE_` variables, but this will take some work to investigation and work and the `CARGO_CFG_` variable, which is available with...

The `Platform` WiX variable still exists and is available even though #126 and #127 have been resolved.

Is `--unit-graph` going to be needed? Based on discussions in #127 and #126, the Host triple can be determined from `rustc --print cfg` and possibly the usage of the [rustc-cfg](https://crates.io/crates/rustc-cfg)...

I am currently favoring the adding deprecation notices to the `--nocapture` flag as this flag is generally only used during debugging and errors. The deprecation notices would then help during...