Vikram Oberoi
Vikram Oberoi
It looks like instructor uses Pydantic's `model_validate_json`. It has a `strict` param which doesn't have the same semantics as `strict` in `json.loads(...,strict=False)` It's possible to do `model_validate_json(json.loads(...))` -- is that...
I think this is a good change and should be merged but it doesn't fulfill my intent behind #612. #612 is about allowing control characters in JSON strings because this...
This functionality was made possible at some point, not sure when it was removed: https://github.com/jxnl/instructor/pull/75
Hey! Thanks for your help on this. Continuing the discussion here since #618 is merged. I'm happy to provide a patch for this functionality. What do you think of merging...
Great -- will merge those semantics. I'll take a crack at a patch.
Fixed in #644.
I use third-party logging tools like those. I don't use those ones in particular, but I'm familiar with them. I don't have issues with such tools. They're important in production...
That works, but something to consider is that clients will frequently want to tie these callbacks to a specific invocation, like so: ```python def get_logging_callback(some_id: str): def log_llm_args(args: list[Any], kwargs:...
Hi! Bumping to see if this is something you'd want to do.
Hey! Sorry just saw this. Yeah I'm fine with that strategy but also, keep me posted on the refactor and I can do it after. Thank you!