Nghia
Nghia
> a second constructor for CustomHeader that takes a `std::unordered_map` > I really like the idea of supplying multiple custom headers. So what do you think about the `std::unordered_map` ?...
> But I am not 100% sure this is all correct, one would need to prototype it and see if it works and then adapt if it does not. I...
@kyamagu I would like to ask how you run the sanitizer with `python` and the shared library ? Or we have to write a sample C++ code for it ?...
@kyamagu Thank you! I will try to set up a CI with the sanitizer.
@yongtang @kyamagu I spun up a CI for `asan` on Linux https://github.com/vnvo2409/io/actions/runs/860162724 ( artifact `test-log` contains `asan` log for each test ). Hope you could find some useful information from...
I am still thinking about it along with #1342. Since environment variable is the only option and reading them is quite expensive, we have to be careful not to affect...
@yongtang @sebastianschramm Please take a look at this [design doc](https://docs.google.com/document/d/19rFf6X2ru2Vr3LHuDC15VXXqoa0eVPo3G3bfhNglRug/edit?usp=sharing) ! Thank you !
@yongtang Gentle ping
@yongtang I think it's OK. In addition, the `aws-sdk-cpp` has already supported it so we only need to call [`SetVersionId`](http://sdk.amazonaws.com/cpp/api/LATEST/class_aws_1_1_s3_1_1_model_1_1_get_object_request.html#a9b1721268a13c89f3e46e12cc5f3b6db) instead of adding the suffix ourselves.
@yongtang > In case of VersionId a suffix in URL like `?versionId=L4kqtJlcpXroDTDmpUMLUo` is enough as the VersionId is for object-level. Sorry I misunderstood your previous comment. If you mean that...