Volker Mische

Results 341 comments of Volker Mische

I don't think I made my point clear enough. I don't want to oppose additional constraints on codecs, I'd like to document on the current state. I think what I...

Here's a quick update after talking to various folks (thanks everyone!). The byte-identical copy of the original data is not possible to enforce. Spec compliant implementations won't be strict enough....

> I get that it might not be suitable for **the** standard way of encrypting data in IPLD. However I still feel it would be very beneficial to support as...

There is a blog post on how to visualize SHA2-256 hashes, which could also provide some ideas/pointers: https://francoisbest.com/posts/2021/hashvatars. They look like this: ![image](https://user-images.githubusercontent.com/42839/115393244-c2a15a80-a1e1-11eb-9ccf-9ca7fc80f831.png)

@hacdias Do you know what it makes it so slow? I'd expect that the slow thing is finding the hash/peers. So the changes to IPLD (I guess that is what...

@mxinden I'd like to get your approval before this one gets merged. As libp2p is one of the users of the identity hash.

> Do I understand correctly that we would need to special-case the identity hash parsing from a `[u8]` here? Yes that's correct. You'd also need to special case here: https://github.com/libp2p/rust-libp2p/blob/a4110a2b6939d5b460f11df6dd158308f517becf/core/src/peer_id.rs#L60-L66...

The with removing the `identity` feature is that libp2p (https://github.com/libp2p/rust-libp2p/blob/5291011c73f8eaf44b3ba4ada873d888ff26e703/core/Cargo.toml#L26) and Forest (https://github.com/ChainSafe/forest/blob/e708777ff6d28aa08ff47560cd62212dfe2fbbb7/node/forest_libp2p/Cargo.toml#L24) are using it atm.

My expectations for "power users" like the FVM were, that you wouldn't rely on the default code table, but you would create your own one, specific to the project. For...