Václav Muzikář

Results 187 comments of Václav Muzikář

@KyriosGN0 Sure, a PR would be welcome!

> it looks like the keycloak deployed the operator does depned on the token being mounted on the pod Yes, we will need to put this into a condition: https://github.com/keycloak/keycloak/blob/7bed44ed7f519f8a1a57eb296370e3ddcedbccc5/operator/src/main/java/org/keycloak/operator/controllers/KeycloakDeploymentDependentResource.java#L438...

> So it needs to be exposed in the CR yes? Yes, it appears we need an option in the CR to set if the SA/CA cert is mounted or...

I would remove rather `--proxy` in 26. It's been deprecated since 24 so should be safe to do even from the RHBK perspective.

> Do you want to consider the pr for 24/25, or just resolve this issue by relying on the workaround of specifying proxy=edge? I would not change 24/25 behaviour. The...

> It's not just that there's a deprecation warning, it's that for this scenario you also need to set proxy=edge. Sorry, missed that. Not sure we really can backport removal...

Thanks for opening this RFE. We had ServiceMonitor support in the old Operator so there is a precedence for that. That said, before adding it I'd like to first discuss...

OTel Metrics will be a preview for unknown amount of time, AFAIK. We do not plan to replace Micrometer metrics any time soon. Hence, +1 for proceeding with this. CC...

jFTR – we have something like this (a [separate job](https://github.com/stianst/keycloak/blob/ed69f65a9cfc64770c4728cf56ea8cd7251f7841/.github/workflows/ci.yml#L761-L785) for testing additional DBs ran on push and nightly) but it's currently used only by EDB.

> IMHO this can be cured by adding it also to the notable changes and not only to the deprecations in the migration guide. +1 Making it default makes sense...