Mate Valko
Mate Valko
@akhilnarang, Docs linked fixed. Semgrep issues one is fixed, the other is kind of a chicken-egg situation. 1. frappe-manual-commit will pass, it was only raised in the test_importer.py 1. I...
@akhilnarang I just realised that i forgot to push the commit where I added `# nosemgrep` for commit in the test_importer.py. Linter will still fail on frappe-modifying-but-not-comitting-other-method, not sure if...
Hey @akhilnarang, sorry, I messed up my branches late yesterday and accidentally combined two different pull request changes together (#26200). All fixed now, won't happen again. Please trigger the tests...
> @akhilnarang, Docs linked fixed. Semgrep issues one is fixed, the other is kind of a chicken-egg situation. > 2. frappe-modifying-but-not-comitting-other-method > > 1. These rules are fired for code...
Hey @akhilnarang, I completed the requested changes, can we proceed? https://github.com/frappe/frappe/pull/26183/commits/0f4e916c8d676153bd99a5543d03d2f0122fe275