Mate Valko

Results 15 comments of Mate Valko

Hey Kinga, need a hand?

My solution 1. Clone the problematic module from github. 2. Open the build folder 3. Open the *.sln file. 4. The Visual Studio will open, and you can select to...

Hey @tinodj, Included the fix for this in my #26183 pull request. One note on your original pull request, It's not enough to update only the [csvutils.py](https://github.com/frappe/frappe/pull/26183/files#diff-6e6dad65b20668c68553233d5bcd65609f8e4d4fc9a5b1954554e50000813e38), as csv files...

Hey @ankush, not sure about adding test-case, which test should I extend? I can only see test_fixtures_import, but I think that is not for data import tool.

Added `test_data.py`, mostly based on code defined in `test_fmt_datetime.py` ``` bench --site localsite run-tests --module frappe.tests.test_data --test test_guess_format Py ssport-frappe 00:17:01 . ---------------------------------------------------------------------- Ran 1 test in 1.677s ```

hey @ankush, if looks good, can you please approve?

hey @ankush, can you please trigger a tett run for the unit tests?

Example files for the UTF8-BOM fix: [utf8.csv](https://github.com/frappe/frappe/files/15140057/utf8.csv) [utf8bom.csv](https://github.com/frappe/frappe/files/15140058/utf8bom.csv) You can compare the two files using the xxd tool: ``` bash $ xxd utf8.csv 00000000: 2263 6f6c 3122 3b22 636f 6c32...