Valentin Maerten

Results 79 comments of Valentin Maerten

Hello! Thanks for your PR. I am closing it. See my comment [here](https://github.com/go-task/task/issues/1066#issuecomment-3651366204)

Indeed dynamic variables and special variables are not evaluated before the include

I tested with the latest `mvdan/sh` main branch, and it works. So we just need to wait for a new `mvdan/sh` release.

@solvingj the lint is failing. Do you still want to work on it?

Thanks for the proposal! I like the idea of aligning with patterns from GitHub Actions and other CI/CD tools. I actually considered this approach myself when designing the feature. The...

> Perhaps we should allow env: and dotenv: to declare secret: true as well? Values in .env files are often secrets. Env are not shown in our logger, I've added...

Currently, `vars` and `preconditions` are not shown in `--dry`, but they are still executed. Only `cmds` and `deps` are skipped. I can see why it might make sense for preconditions...

Need to wait before the next golang release because it requires go 1.24 (and we support two last go version)

Go 1.25 has been released, so we can merge this one

I think this is a good proposal and the right way to go. Scoping variables has been missing, and its absence often leads to confusion.